Open
Conversation
b0ink
requested changes
Feb 15, 2026
Member
b0ink
left a comment
b0ink
left a comment
There was a problem hiding this comment.
The project is not being retrieved correctly - I enabled groups as a Convenor then tried to access the groups route as a student, and it could not fetch the project or unit, resulting in errors
| <div class="container"> | ||
| @if (unit.hasGroupwork()) { | ||
| <f-group-set-manager [project]="project" [unit]="unit" [selectedGroupSet]="selectedGroupSet"> | ||
| <div class="container" *ngIf="project$ | async as project"> |
| export class ProjectGroupsComponent { | ||
| @Input() unit: Unit; | ||
| @Input() project: Project; | ||
| @Input() project$: Observable<Project>; |
Member
There was a problem hiding this comment.
You'll need to actually fetch the project from somewhere, currently the project$ does not resolve to anything.
Refer to the tutorials component to see how we fetch the project using its id - once all components are migrated we'll implement a service that automatically resolves project/units during the routing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the student Groups List state from legacy CoffeeScript/AngularJS to TypeScript/Angular. This move completes the transition of the student-facing group management interface to the modern Angular framework.
The state has been updated to sit under the
projects2parent state, inheriting the project data via the standardproject$observable pattern used across the repository. This resolved initialTypeErrorissues by ensuring that the component only renders once the unit data has been successfully resolved.Key Changes:
projects/states/groups/groups.coffeeandgroups.tpl.html.projects/groupsstate indoubtfire.states.tsas a child ofprojects2.ProjectGroupsComponentand its template to handle theproject$observable resolve, matching the architecture of theProjectDashboardComponent.doubtfire.projects.states.groupsmodule from the AngularJS bootstrap process.Fixes # (migration)
Type of change
How Has This Been Tested?
The migration was verified by testing the end-to-end workflow between Staff and Student roles:
#/projects2/:id/groups.Screenshots
Before Migration (AngularJS)
After Migration (Angular) - Groups Enabled
After Migration (Angular) - No Groups
Testing Checklist:
Checklist: